Re: [RESEND PATCH v2] memory-hotplug: fix store_mem_state() return value

[Reza Arbab]

On Wed, Aug 31, 2016 at 02:06:14PM -0700, David Rientjes wrote:
The correct fix is for store_mem_state() to return -EINVAL when 
device_online() returns non-zero.

Let me put it to you this way--which one of these sysfs operations is 
behaving correctly?

        # cd /sys/devices/system/memory/memory0
        # cat online
        1
        # echo 1 > online; echo $?
        0

or

        # cd /sys/devices/system/memory/memory0
        # cat state
        online
        # echo online > state; echo $?
        -bash: echo: write error: Invalid argument
        1

One of them should change to match the other.

--
Reza Arbab