> -----Original Message----- > From: Axel Lin [mailto:axel....@ingics.com] > Sent: 30 August 2016 19:24 > To: Kishon Vijay Abraham I > Cc: Pramod Kumar; Andrew Lunn; Jon Mason; linux-kernel@vger.kernel.org; > Axel Lin > Subject: [RESEND AGAIN][PATCH 2/2] phy: bcm-ns2-pcie: Set missing .owner > field in ns2_pci_phy_ops > > Add missing .owner field in ns2_pci_phy_ops, which is used for refcounting. > While at it, also makes ns2_pci_phy_ops const as it's never get modified. > > Signed-off-by: Axel Lin <axel....@ingics.com> > Reviewed-and-tested-by: Jon Mason <jon.ma...@broadcom.com> > --- > This was sent on http://www.spinics.net/lists/netdev/msg383514.html > Resent on https://lkml.org/lkml/2016/8/12/659 > drivers/phy/phy-bcm-ns2-pcie.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/phy/phy-bcm-ns2-pcie.c b/drivers/phy/phy-bcm-ns2-pcie.c > index ee61772..4c7d11d 100644 > --- a/drivers/phy/phy-bcm-ns2-pcie.c > +++ b/drivers/phy/phy-bcm-ns2-pcie.c > @@ -47,8 +47,9 @@ err: > return rc; > } > > -static struct phy_ops ns2_pci_phy_ops = { > +static const struct phy_ops ns2_pci_phy_ops = { > .init = ns2_pci_phy_init, > + .owner = THIS_MODULE, > }; > > static int ns2_pci_phy_probe(struct mdio_device *mdiodev) > --
Looks fine to me. Reviewed-by: Pramod Kumar <pramo...@broadcom.com> > 2.5.0
