On Tue, Aug 23, 2016 at 04:05:29PM +0200, Miklos Szeredi wrote: > This is trivial to do: > > - add flags argument to foo_rename() > - check if flags is zero > - assign foo_rename() to .rename2 instead of .rename > > This doesn't mean it's impossible to support RENAME_NOREPLACE for these > filesystems, but it is not trivial, like for local filesystems. > RENAME_NOREPLACE must guarantee atomicity (i.e. it shouldn't be possible > for a file to be created on one host while it is overwritten by rename on > another host). > > Filesystems converted: > > 9p, afs, ceph, coda, ecryptfs, exofs, kernfs, lustre, ncpfs, nfs, ocfs2, > orangefs. > > After this, we can get rid of the duplicate interfaces for rename. > > Signed-off-by: Miklos Szeredi <mszer...@redhat.com> > Cc: Eric Van Hensbergen <eri...@gmail.com> > Cc: David Howells <dhowe...@redhat.com> > Cc: Ilya Dryomov <idryo...@gmail.com> > Cc: Jan Harkes <jahar...@cs.cmu.edu> > Cc: Tyler Hicks <tyhi...@canonical.com> > Cc: Boaz Harrosh <o...@electrozaur.com> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > Cc: Oleg Drokin <oleg.dro...@intel.com> > Cc: Trond Myklebust <trond.mykleb...@primarydata.com> > Cc: Mark Fasheh <mfas...@suse.com> > Cc: Mike Marshall <hub...@omnibond.com>
Acked-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
