On 08/09/2016 08:57 AM, york....@nxp.com wrote: > On 08/08/2016 11:56 PM, Borislav Petkov wrote: >> On Tue, Aug 09, 2016 at 05:06:39AM +0000, york sun wrote: >>> It is uncorrectable. DDR controller can only report the error. I don't >>> believe EDAC driver can do more. For the same reason I said we can leave >>> RXFE as is, even for e500v1 case (with RIO or PCI is enabled). Nothing >>> can be done with uncorrectable error. >> >> Of course it can: it can panic the machine so that it doesn't corrupt >> data on secondary storage. You might consider whether this is a better >> course of action instead of only reporting the error. >> > > Boris, > > My opinion is the error shouldn't happen at the first place. It usually > means wrong configuration or physical error on the hardware. An EDAC > driver can report these errors. How far you want to go on the error > handling is up for discussion. I don't think we should include those > improvement in this patch set. >
I want to add this, normally uncorrectable errors don't trigger machine check on e500v1. RXFE controls different interrupt on e500v2. e500mc doesn't support RXFE. Together with the reason I explained, I believe EDAC driver shouldn't change RXFE. I hope I made it clear. York
