Hi, 1) Sorry about the change log, I will try to be clearer next time. 2+3) The issue is not that the station is not known, it's that wl_sta->wl was null. wl member is now completely removed from wl_sta (PATCH 2/2) and hw is sent directly from mac80211 to the driver (so it can get hw->priv).
4) Sorry, I just saw now that everything has a space before the line. I used checkpatch.pl and it was ok. I will be more careful next time. BR, Max ________________________________________ From: Johannes Berg [johan...@sipsolutions.net] Sent: Friday, August 05, 2016 3:24 PM To: Altshul, Maxim; linux-kernel@vger.kernel.org Cc: john.stu...@linaro.org; Kalle Valo; Eliad Peller; Machani, Yaniv Subject: Re: [PATCH 1/2] mac80211/wlcore: Add ieee80211_hw variable to get_expected_throughput On Fri, 2016-08-05 at 14:22 +0200, Johannes Berg wrote: > On Thu, 2016-08-04 at 15:43 +0300, Maxim Altshul wrote: > > - The variable is added to allow the driver an easy access > > to it's own hw->priv when the op is invoked. > > > > - Change wlcore op accordingly. > > > I'm applying this now, with a big BUT: > > 1) your changelog is crap - I've rewritten it to indicate what's > going > on > > 2) I think the change makes sense, but as far as fixing the bug is > concerned it's actually completely stupid > > 3) I expect you to submit a proper bugfix for mac80211 ASAP, to not > call into the driver before the station is actually known to the > driver. 4) please indent your code properly when submitting... johannes
