On Tue, 2 Aug 2016 20:14:09 +0800 Baole Ni <[email protected]> wrote:
> I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > NACK! I find 0444 more readable than S_IRUSR | S_IRGRP | S_IROTH. -- Steve > Signed-off-by: Chuansheng Liu <[email protected]> > Signed-off-by: Baole Ni <[email protected]> > --- > kernel/time/clocksource.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/kernel/time/clocksource.c b/kernel/time/clocksource.c > index 56ece14..9656bb1 100644 > --- a/kernel/time/clocksource.c > +++ b/kernel/time/clocksource.c > @@ -972,12 +972,12 @@ sysfs_show_available_clocksources(struct device *dev, > /* > * Sysfs setup bits: > */ > -static DEVICE_ATTR(current_clocksource, 0644, > sysfs_show_current_clocksources, > +static DEVICE_ATTR(current_clocksource, S_IRUSR | S_IWUSR | S_IRGRP | > S_IROTH, sysfs_show_current_clocksources, > sysfs_override_clocksource); > > -static DEVICE_ATTR(unbind_clocksource, 0200, NULL, sysfs_unbind_clocksource); > +static DEVICE_ATTR(unbind_clocksource, S_IWUSR, NULL, > sysfs_unbind_clocksource); > > -static DEVICE_ATTR(available_clocksource, 0444, > +static DEVICE_ATTR(available_clocksource, S_IRUSR | S_IRGRP | S_IROTH, > sysfs_show_available_clocksources, NULL); > > static struct bus_type clocksource_subsys = {
