On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote: > Per Jesse Brandeburg, e1000e should be using flags for this sort of > thing. > > Littering functional code with device-specific checks is much messier > than > simply checking a flag, and having device-specific init set flags as > needed. > There are probably a number of other cases in the e1000e code that > could/should be converted similarly. > > At present, this patch is a follow-up to the previously submitted 2 > patches, but I can redo the series to omit the conversion to a switch > entirely, if so desired. > > Suggested-by: Jesse Brandeburg <jesse.brandeb...@intel.com> > CC: Jesse Brandeburg <jesse.brandeb...@intel.com> > CC: Jeff Kirsher <jeffrey.t.kirs...@intel.com> > CC: intel-wired-...@lists.osuosl.org > CC: net...@vger.kernel.org > Signed-off-by: Jarod Wilson <ja...@redhat.com> > --- > drivers/net/ethernet/intel/e1000e/82571.c | 6 ++++-- > drivers/net/ethernet/intel/e1000e/e1000.h | 1 + > drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 ++- > drivers/net/ethernet/intel/e1000e/netdev.c | 10 ++-------- > 4 files changed, 9 insertions(+), 11 deletions(-)
This generates a compile issue, so I will be dropping this patch and will await an update.
signature.asc
Description: This is a digitally signed message part
