On 21-07-16, 16:29, Steve Muckle wrote:
> On Thu, Jul 21, 2016 at 04:21:31PM -0700, Steve Muckle wrote:
> > On Thu, Jul 21, 2016 at 01:30:41PM -0700, Viresh Kumar wrote:
> > > Okay, but in that case shouldn't we do something like this:
> > >
> > > unsigned int cpufreq_driver_resolve_freq(struct cpufreq_policy *policy,
> > > unsigned int target_freq)
> > > {
> > > target_freq = clamp_val(target_freq, policy->min, policy->max);
> > > policy->cached_target_freq = target_freq;
> > >
> > > if (cpufreq_driver->target_index) {
> > > policy->cached_resolved_idx =
> > > cpufreq_frequency_table_target(policy,
> > > target_freq,
> > >
> > > CPUFREQ_RELATION_L);
> > > return
> > > policy->freq_table[policy->cached_resolved_idx].frequency;
> > > }
> > >
> > > if (cpufreq_driver->resolve_freq)
> > > return cpufreq_driver->resolve_freq(policy, target_freq);
> > > }
> >
> > Thanks for the review.
> >
> > My thinking (noted in the commit text) was that the caller of
> > cpufreq_driver_resolve_freq() would verify that the driver supported the
> > proper calls before using this API. This way it can be checked once,
> > presumably in a governor's init routine. Checking the pointer over and
> > over again in a fast path is wasteful.
>
> I guess this isn't immediately possible as the governor can't see
> cpufreq_driver. I was hoping to change that however to allow
> cpufreq_driver_resolve_freq() to be inlined in schedutil to get rid of
> another function call...
Well, you can do that by moving the newly created routine to
cpufreq.h.
--
viresh
