> -----Original Message----- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: 12 July 2016 16:35 > To: liudongdong (C) > Cc: helg...@kernel.org; raf...@kernel.org; lorenzo.pieral...@arm.com; > t...@semihalf.com; Wangzhou (B); pratyush.an...@gmail.com; linux- > p...@vger.kernel.org; linux-a...@vger.kernel.org; linux- > ker...@vger.kernel.org; j...@redhat.com; Gabriele Paoloni; Chenxin > (Charles); Linuxarm > Subject: Re: [RFC PATCH 3/3] PCI/ACPI: hisi: Add ACPI support for > HiSilicon SoCs Host Controllers > > On Tuesday, July 12, 2016 10:42:24 AM CEST Dongdong Liu wrote: > > MAINTAINERS | 1 + > > drivers/pci/host/Kconfig | 7 ++ > > drivers/pci/host/Makefile | 1 + > > drivers/pci/host/mcfg-quirks.c | 8 ++ > > drivers/pci/host/mcfg-quirks.h | 8 ++ > > drivers/pci/host/pcie-hisi-acpi.c | 151 > ++++++++++++++++++++++++++++++++++++++ > > drivers/pci/host/pcie-hisi.c | 2 - > > drivers/pci/host/pcie-hisi.h | 2 + > > 8 files changed, 178 insertions(+), 2 deletions(-) > > create mode 100644 drivers/pci/host/pcie-hisi-acpi.c > > > > > > Please keep the quirks separate from the PCI host drivers. > > The ACPI code includes its own host driver and the only thing > you need to override here is the config space access, so just put that > into drivers/acpi/
Hi Arnd, thanks for replying. Basically we just followed what Tomasz has done in "[RFC PATCH v4 0/5] ECAM quirks handling for ARM64 platforms" In this case the ThunderX quirks have been defined in "drivers/pci/host/pci-thunder-pem.c". Cheers Gab > > Arnd
