On Fri, Jul 08, 2016 at 11:26:59AM +0200, Ingo Molnar wrote: > So why does neither the changelog nor the code comment actually _explain_ > this and > give aa bit of a background about what 'syndrome information' is and why we > want > to have kernel support for it? > > This is why I hate kernel tooling that is not part of the kernel tree - the > mcelog > patch (hopefully ...) would tell us more about all this - but it's separate > and > this patch does not tell us anything ...
Ah, this is one of those omissions where we forgot to explain, sorry. How about this: "The syndrome value is used to uniquely identify which bits of a reported ECC error are corrupted." Do you want it as a comment in the code or in the commit message or both? Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.