On Tue, Jun 28, 2016 at 12:06:22PM +0100, Will Deacon wrote: > On Tue, Jun 21, 2016 at 12:12:36PM +0100, Suzuki K Poulose wrote: > > +static struct attribute_group cpuregs_attr_group = { > > + .attrs = cpuregs_attrs, > > + .name = "identification" > > +}; > > This makes sense because MIDR/REVIDR belong to the "Identification" > functional group of registers, however I wonder if we should put this > under a directory called "regs" or similar, so that we don't have a > confusing top-level directory where "identification" lives alongside > things like "hotplug" and "cpuidle".
IMO, there are too many subdirectories and I don't think we would expose any other registers than the ID ones. -- Catalin