> -----Original Message----- > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > Sent: Tuesday, June 21, 2016 3:24 PM > To: Tan, Jui Nee <jui.nee....@intel.com> > Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com>; > heikki.kroge...@linux.intel.com; t...@linutronix.de; mi...@redhat.com; > h...@zytor.com; x...@kernel.org; pty...@xes-inc.com; > lee.jo...@linaro.org; linux-g...@vger.kernel.org; linux- > ker...@vger.kernel.org; Linus Walleij <linus.wall...@linaro.org>; Yong, > Jonathan <jonathan.y...@intel.com>; Yu, Ong Hock > <ong.hock...@intel.com>; Voon, Weifeng <weifeng.v...@intel.com>; Wan > Mohamad, Wan Ahmad Zainie > <wan.ahmad.zainie.wan.moha...@intel.com> > Subject: Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband > bridge support driver for Intel SOC's > > On Tue, Jun 21, 2016 at 05:03:20AM +0000, Tan, Jui Nee wrote: > > > Maybe, or make it modular and use MODULE_DEVICE_TABLE(x86cpu, ...) > > > to match the corresponding CPUs. > > > > We need CONFIG_X86_INTEL_NON_ACPI Kconfig option to select > CONFIG_PINCTRL. > > This is to solve kbuidbot complaint about kernel configuration, i.e. > > CONFIG_PINCTRL=n. Appreciate if you could advise something on this. > > Good point. > > Then I guess you might add similar Kconfig option but can you call it > something else than CONFIG_X86_INTEL_NON_ACPI. Perhaps something > that relates to the actual product so distro people can then decide whether > they want to support it or not. Along the lines of CONFIG_X86_INTEL_CE and > so on. Thanks for your suggestion. CONFIG_X86_INTEL_NON_ACPI will be renamed to CONFIG_X86_INTEL_APL in next patch-set.