Hi Ingo, >>> SMP does ECB crypto on stack buffers. This is complicated and >>> fragile, and it will not work if the stack is virtually allocated. >>> >>> Switch to the crypto_cipher interface, which is simpler and safer. >>> >>> Cc: Marcel Holtmann <[email protected]> >>> Cc: Gustavo Padovan <[email protected]> >>> Cc: Johan Hedberg <[email protected]> >>> Cc: "David S. Miller" <[email protected]> >>> Cc: [email protected] >>> Cc: [email protected] >>> Acked-by: Herbert Xu <[email protected]> >>> Acked-and-tested-by: Johan Hedberg <[email protected]> >>> Signed-off-by: Andy Lutomirski <[email protected]> >>> --- >>> net/bluetooth/smp.c | 67 >>> ++++++++++++++++++++++------------------------------- >>> 1 file changed, 28 insertions(+), 39 deletions(-) >> >> patch has been applied to bluetooth-next tree. > > Sadly carrying this separately will delay the virtual kernel stacks feature > by a > kernel cycle, because it's a must-have prerequisite.
I can take it back out, but then I have the fear the the ECDH change to use KPP for SMP might be the one that has to wait a kernel cycle. Either way is fine with me, but I want to avoid nasty merge conflicts in the Bluetooth SMP code. Regards Marcel
