Hi,
On Fri, 17 Jun 2016 10:48:41 +0100
Juri Lelli <juri.le...@arm.com> wrote:
> setup_new_dl_entity() takes two parameters, but it only actually uses
> one of them to setup a new dl_entity.
>
> Remove the second, useless, parameter.
Funnily enough, I was adding something similar in my local queue :)
Looks good to me
Thanks,
Luca
>
> Cc: Ingo Molnar <mi...@redhat.com>
> Cc: Peter Zijlstra <pet...@infradead.org>
> Cc: Steven Rostedt <rost...@goodmis.org>
> Cc: Luca Abeni <luca.ab...@unitn.it>
> Signed-off-by: Juri Lelli <juri.le...@arm.com>
> ---
> kernel/sched/deadline.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
> index fcb7f0217ff4..5229788a4765 100644
> --- a/kernel/sched/deadline.c
> +++ b/kernel/sched/deadline.c
> @@ -346,8 +346,7 @@ static void check_preempt_curr_dl(struct rq *rq,
> struct task_struct *p,
> * one, and to (try to!) reconcile itself with its own scheduling
> * parameters.
> */
> -static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se,
> - struct sched_dl_entity *pi_se)
> +static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se)
> {
> struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
> struct rq *rq = rq_of_dl_rq(dl_rq);
> @@ -367,8 +366,8 @@ static inline void setup_new_dl_entity(struct
> sched_dl_entity *dl_se,
> * future; in fact, we must consider execution overheads
> (time
> * spent on hardirq context, etc.).
> */
> - dl_se->deadline = rq_clock(rq) + pi_se->dl_deadline;
> - dl_se->runtime = pi_se->dl_runtime;
> + dl_se->deadline = rq_clock(rq) + dl_se->dl_deadline;
> + dl_se->runtime = dl_se->dl_runtime;
> }
>
> /*
> @@ -1721,7 +1720,7 @@ static void switched_from_dl(struct rq *rq,
> struct task_struct *p) static void switched_to_dl(struct rq *rq,
> struct task_struct *p) {
> if (dl_time_before(p->dl.deadline, rq_clock(rq)))
> - setup_new_dl_entity(&p->dl, &p->dl);
> + setup_new_dl_entity(&p->dl);
>
> if (task_on_rq_queued(p) && rq->curr != p) {
> #ifdef CONFIG_SMP
