Re: [patch] devlink: clean up a condition

[Or Gerlitz]

On 6/16/2016 9:50 AM, Dan Carpenter wrote:

Presumably having a _get() function implies that we also have a _set()
function but lets make it match when we're calling.

Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/net/core/devlink.c b/net/core/devlink.c
index a4f88cb..b2e592a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct 
sk_buff *skb,

mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]); - if (ops && ops->eswitch_mode_get)

+       if (ops && ops->eswitch_mode_set)
                return ops->eswitch_mode_set(devlink, mode);
        return -EOPNOTSUPP;
  }

good catch Dan, we will incorporate that into the patch set