Hi Pramod,
On 05/06/2016 02:46 AM, Pramod Gurav wrote:
> uart_change_pm is used to turn on the UART controller resources and
> change UART's PM status. On failure to allocate pages the controller
> be left in ON state. This will change the state to OFF on failure.
>
> Signed-off-by: Pramod Gurav <pramod.gu...@linaro.org>
> ---
> drivers/tty/serial/serial_core.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c
> b/drivers/tty/serial/serial_core.c
> index 62fe368..58af2e9 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -156,9 +156,10 @@ static int uart_port_startup(struct tty_struct *tty,
> struct uart_state *state,
> if (!state->xmit.buf) {
> /* This is protected by the per port mutex */
> page = get_zeroed_page(GFP_KERNEL);
> - if (!page)
> + if (!page) {
if (!uart_console(uport))
Otherwise, you'll be powering off the console.
Just out of curiosity, did you actually hit this error?
Regards,
Peter Hurley
> + uart_change_pm(state, UART_PM_STATE_OFF);
> return -ENOMEM;
> -
> + }
> state->xmit.buf = (unsigned char *) page;
> uart_circ_clear(&state->xmit);
> }
>
