Hello there, 1.
linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:392]: (style) Redundant condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always true. Source code is if (!(mday >= 1) && (mday <= 31)) Maybe better code if (!((mday >= 1) && (mday <= 31))) 2. linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:464]: (style) Redundant condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always true. Duplicate. Also in the same file: [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a value that is never used. [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a value that is never used. Regards David Binderman
