On Tue, May 24, 2016 at 3:13 PM, Laxman Dewangan <ldewan...@nvidia.com> wrote:
> Implement gpio_get_direction() callback for MAX77620 GPIO. > This is useful for debugfs and the userspace ABI. > > Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> > #include <linux/gpio/driver.h> > +#include <linux/gpio.h> No. This is a sign that something is wrong, no driver should include this unless it is using GPIOs as a resource itself. > + return (val & MAX77620_CNFG_GPIO_DIR_MASK) ? > + GPIOF_DIR_IN : GPIOF_DIR_OUT; Just return 0 or 1. The driver-internal API isn't smarter than that. Yours, Linus Walleij
