On 05/27/16 at 06:06P, Paolo Bonzini wrote: > > > On 27/05/2016 17:40, Andy Lutomirski wrote: > > On Thu, May 26, 2016 at 11:17 PM, Minfei Huang <mngh...@gmail.com> wrote: > >> There is a generic function __pvclock_read_cycles to be used to get both > >> flags and cycles. For function pvclock_read_flags, it's useless to get > >> cycles value. To make this function be more effective, add a new wrapper > >> function to only get variable flags. > > > > Why not just get rid of this function entirely? > > I agree. If you want to abstract the retry logic, perhaps you can add
Hmm, I will get rid of pvclock_read_flags, and repost it. Thanks Minfei > pvclock_read_{begin,retry} functions like seqlock_read_{begin,retry}? > > Thanks, > > Paolo