Set default config values for 'annotate' section with 'annotate_config_items[]' instead of actual bool type values. (e.g. using annotate_config_items[CONFIG_ANNOTATE_USE_OFFSET].value instead of 'true' bool type value for 'annotate.use_offset'.)
Cc: Namhyung Kim <namhy...@kernel.org> Cc: Jiri Olsa <jo...@kernel.org> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Alexander Shishkin <alexander.shish...@linux.intel.com> Signed-off-by: Taeung Song <treeze.tae...@gmail.com> --- tools/perf/perf.c | 1 + tools/perf/ui/browser.h | 1 + tools/perf/ui/browsers/annotate.c | 15 +++++++++++---- tools/perf/util/config.h | 6 ++++++ 4 files changed, 19 insertions(+), 4 deletions(-) diff --git a/tools/perf/perf.c b/tools/perf/perf.c index e140b551..d5541fa 100644 --- a/tools/perf/perf.c +++ b/tools/perf/perf.c @@ -80,6 +80,7 @@ struct pager_config { static void perf_default_config_init(void) { default_colors_config_init(); + default_annotate_config_init(); } static int pager_command_config(const char *var, const char *value, void *data) diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h index 46921e5..b7dc178 100644 --- a/tools/perf/ui/browser.h +++ b/tools/perf/ui/browser.h @@ -77,4 +77,5 @@ void ui_browser__init(void); void annotate_browser__init(void); void default_colors_config_init(void); +void default_annotate_config_init(void); #endif /* _PERF_UI_BROWSER_H_ */ diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c index 4fc208e..35c2547 100644 --- a/tools/perf/ui/browsers/annotate.c +++ b/tools/perf/ui/browsers/annotate.c @@ -37,10 +37,7 @@ static struct annotate_browser_opt { show_linenr, show_nr_jumps, show_total_period; -} annotate_browser__opts = { - .use_offset = true, - .jump_arrows = true, -}; +} annotate_browser__opts; struct annotate_browser { struct ui_browser b; @@ -1158,6 +1155,16 @@ static int annotate__config(const char *var, const char *value, return 0; } +void default_annotate_config_init(void) +{ + annotate_browser__opts.hide_src_code = CONF_ANNOTATE_DEFAULT_VAL(HIDE_SRC_CODE, b); + annotate_browser__opts.use_offset = CONF_ANNOTATE_DEFAULT_VAL(USE_OFFSET, b); + annotate_browser__opts.jump_arrows = CONF_ANNOTATE_DEFAULT_VAL(JUMP_ARROWS, b); + annotate_browser__opts.show_linenr = CONF_ANNOTATE_DEFAULT_VAL(SHOW_LINENR, b); + annotate_browser__opts.show_nr_jumps = CONF_ANNOTATE_DEFAULT_VAL(SHOW_NR_JUMPS, b); + annotate_browser__opts.show_total_period = CONF_ANNOTATE_DEFAULT_VAL(SHOW_TOTAL_PERIOD, b); +} + void annotate_browser__init(void) { perf_config(annotate__config, NULL); diff --git a/tools/perf/util/config.h b/tools/perf/util/config.h index 696e5bc..7b70971 100644 --- a/tools/perf/util/config.h +++ b/tools/perf/util/config.h @@ -88,6 +88,12 @@ enum annotate_config_items_idx { #define CONF_END() \ { .name = NULL } +#define CONF_DEFAULT_VAL(section, name, field) \ + section##_config_items[CONFIG_##name].value.field + +#define CONF_ANNOTATE_DEFAULT_VAL(name, field) \ + CONF_DEFAULT_VAL(annotate, ANNOTATE_##name, field) + extern const struct default_config_item colors_config_items[]; extern const struct default_config_item annotate_config_items[]; -- 2.5.0