On Sat, Jan 27, 2007 at 11:45:05AM +1100, Herbert Xu wrote: > David Miller <[EMAIL PROTECTED]> wrote: > > > > Shaper is actually OK. None of these hardware header callbacks > > should be invoked if the device is down. Yet, this is what is > > accidently being allowed in the AF_PACKET socket layer. > > Hmm, what if the device goes down after the check?
In fact, the shaper device doesn't even seem to take a ref count of the device it has attached to. So that device can go away at any time. What's more, there are drivers that can change hard_header at run-time (s390). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
