> -----Original Message-----
> From: Laura Abbott [mailto:labb...@redhat.com]
> Sent: Monday, May 16, 2016 12:12 PM
> To: Limonciello, Mario <mario_limoncie...@dell.com>;
> ming....@canonical.com
> Cc: LKML <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] dell_rbu: Don't fallback to userhelper when loading
> firmware
>
> On 05/16/2016 08:41 AM, Mario Limonciello wrote:
> > dell_rbu previously would allow a userspace application to craft the
> > payload after dell_rbu was loaded and abuse the udev userspace API.
> >
> > Instead require the payload to be crafted and placed in
> > /lib/firmware/dell_rbu ahead of time.
> >
> > This adjusts dell_rbu to immediately load the firmware from
> > /lib/firmware/dell_rbu when "init" is passed into image_type using the
> > kernel helper.
>
> Looks like you missed the Signed-off-by line.
>
> Can you also drop the Kconfig dependency on
> CONFIG_FW_LOADER_USER_HELPER?
>
> Thanks,
> Laura
Sure thing.
>
> > ---
> > drivers/firmware/dell_rbu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/firmware/dell_rbu.c b/drivers/firmware/dell_rbu.c
> > index d5f5b98..5ecf043 100644
> > --- a/drivers/firmware/dell_rbu.c
> > +++ b/drivers/firmware/dell_rbu.c
> > @@ -677,7 +677,7 @@ static ssize_t write_rbu_image_type(struct file *filp,
> struct kobject *kobj,
> > if (!rbu_data.entry_created) {
> > spin_unlock(&rbu_data.lock);
> > req_firm_rc =
> request_firmware_nowait(THIS_MODULE,
> > -
> FW_ACTION_NOHOTPLUG,
> > + FW_ACTION_HOTPLUG,
> > "dell_rbu",
> > &rbu_device->dev,
> > GFP_KERNEL,
> >
