Em Fri, May 13, 2016 at 07:55:58AM +0000, Wang Nan escreveu:
> Extract event reader to __perf_evlist__mmap_read(). Future commit will
> feed it with manually computed 'head' and 'old' pointers.

why not use the perf_mmap__read() directly then?

- Arnaldo
 
> Signed-off-by: Wang Nan <wangn...@huawei.com>
> Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
> Cc: Peter Zijlstra <pet...@infradead.org>
> Cc: Zefan Li <lize...@huawei.com>
> Cc: pi3or...@163.com
> ---
>  tools/perf/util/evlist.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
> index c4bfe11..5e86972 100644
> --- a/tools/perf/util/evlist.c
> +++ b/tools/perf/util/evlist.c
> @@ -749,6 +749,13 @@ broken_event:
>       return event;
>  }
>  
> +static union perf_event *
> +__perf_evlist__mmap_read(struct perf_mmap *md, bool overwrite, u64 head,
> +                      u64 old, u64 *prev)
> +{
> +     return perf_mmap__read(md, overwrite, old, head, prev);
> +}
> +
>  union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx)
>  {
>       struct perf_mmap *md = &evlist->mmap[idx];
> @@ -763,7 +770,8 @@ union perf_event *perf_evlist__mmap_read(struct 
> perf_evlist *evlist, int idx)
>  
>       head = perf_mmap__read_head(md);
>  
> -     return perf_mmap__read(md, evlist->overwrite, old, head, &md->prev);
> +     return __perf_evlist__mmap_read(md, evlist->overwrite, head,
> +                                     old, &md->prev);
>  }
>  
>  union perf_event *
> -- 
> 1.8.3.4

Reply via email to