On Thu, 25 Jan 2007 05:42:42 +0000 Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> On Wed, Jan 24, 2007 at 12:11:30PM +0100, S?bastien Dugu? wrote: > > > > + if (unlikely(!notify->sigq)) > > > > + return -EAGAIN; > > > > > > Did this just leak a ref on the task_struct? > > > > > > > No, the ref is released in really_put_req() when we dispose of > > the iocb. > > And the code really needs a comment explaining this. I tripped over > this before, and I think it's even already the second time Andrew > stumbled over it. > OK, will do. Thanks, Sébastien. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/