On Sat, 2016-05-07 at 02:24 +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > > intel_pstate_get() contains a local variable that's initialized but > never used and it can be written in fewer lines of code, so clean > it up. > > Signed-off-by: Rafael J. Wysocki <rafael.j.wyso...@intel.com> Acked-by: Srinivas Pandruvada <srinivas.pandruv...@linux.intel.com>
> --- > drivers/cpufreq/intel_pstate.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > Index: linux-pm/drivers/cpufreq/intel_pstate.c > =================================================================== > --- linux-pm.orig/drivers/cpufreq/intel_pstate.c > +++ linux-pm/drivers/cpufreq/intel_pstate.c > @@ -1390,14 +1390,9 @@ static int intel_pstate_init_cpu(unsigne > > static unsigned int intel_pstate_get(unsigned int cpu_num) > { > - struct sample *sample; > - struct cpudata *cpu; > + struct cpudata *cpu = all_cpu_data[cpu_num]; > > - cpu = all_cpu_data[cpu_num]; > - if (!cpu) > - return 0; > - sample = &cpu->sample; > - return get_avg_frequency(cpu); > + return cpu ? get_avg_frequency(cpu) : 0; > } > > static void intel_pstate_set_update_util_hook(unsigned int cpu_num) >