Muhammad Falak R Wani <falakre...@gmail.com> wrote: > Never use sg++, always use sg = sg_next(sg). Scatterlist entries can > be combined if the memory is contiguous but sg++ won't know about > that. It sure would run on the slower side. > But regardless, sg++ should never be used, only sg_next is safe. > > Signed-off-by: Muhammad Falak R Wani <falakre...@gmail.com>
No please the only difference between sg_next and sg++ is chaining, which is irrelevant here. Patch rejected. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
