Hi David, Thanks for providing input over the patch. Will address the comment as described below.
> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: 24 April 2016 23:48 > To: pramod.ku...@broadcom.com > Cc: robh...@kernel.org; catalin.mari...@arm.com; will.dea...@arm.com; > yamada.masah...@socionext.com; w...@csie.org; bcm-kernel-feedback- > l...@broadcom.com; pawel.m...@arm.com; mark.rutl...@arm.com; > a...@arndb.de; suzuki.poul...@arm.com; punit.agra...@arm.com; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; anup.pa...@broadcom.com > Subject: Re: [PATCH 1/6] bus: Add shared MDIO bus framework > > From: Pramod Kumar <pramod.ku...@broadcom.com> > Date: Thu, 21 Apr 2016 14:48:38 +0530 > > > +struct shared_mdio_master *shared_mdio_alloc_master(struct device > *parent, > > + struct device_node *node) > > +{ > > + int ret = 0; > > + struct shared_mdio_master *master; > > Always order local variable declarations in reverse christmas tree (longest to > shortest line) order. > Sure. Next patch will address this. > > +static int shared_mdio_driver_probe(struct device *dev) { > > + int rc; > > + struct shared_mdio_master *master = to_shared_mdio_master(dev); > > + struct shared_mdio_driver *drv = to_shared_mdio_driver(dev->driver); > > Likewise. Sure. > Please audit your entire submission for this issue. Sure. I'll audit the entire patch set for above issue. Regards, Pramod
