On Thu, Jan 18, 2007 at 10:55:54PM +0100, Adrian Bunk wrote: > Let's start with a small exercise: > > Consider sparse tells you about a global function: > warning: symbol 'unionfs_d_revalidate_wrap' was not declared. Should > it be static? I ran sparse last week, and cleaned up a few things (not commited to korg yet). I'll use your patch instead. > This patch contains the following possible cleanups: > - every function should #include the headers containing the prototypes > of it's global functions > - static functions in C files shouldn't be marked "inline", gcc should > know best when to inline them > - make needlessly global code static > - #if 0 the following unused global function: > - stale_inode.c: is_stale_inode() > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks. Josef "Jeff" Sipek.
-- NT is to UNIX what a doughnut is to a particle accelerator. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
