On Fri, 2007-01-19 at 07:43 -0800, Randy Dunlap wrote: > On Fri, 19 Jan 2007 10:11:10 -0500 Benjamin Romer wrote: > > > On Fri, 2007-01-19 at 09:19 +0530, Vivek Goyal wrote: > > > On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: > > > [..] > > > > > > > > > > > > OK, here's the updated patch that uses the new definition and fixes > > > > > > up > > > > > > the other places that use it. I built and tested this on the > > > > > > ES7000/ONE > > > > > > and it works well. :) > > > > > > > > > > Cool. > > > > > > > > > > I hate to pick nits by why the double underscore on dest? > > > > > > > > > > > > > It was defined that way in the updated structure definition you sent in > > > > a previous mail, so I figured you wanted it that way. Here's another > > > > revision with the double underscores removed. :) > > > > > > > > -- Ben > > > > > > > > > > This patch looks good to me. You might want to provide some description > > > too for changelog. > > > > > > Thanks > > > Vivek > > > > A simple description would look something like: > > > > - Updated 4-bit IO-APIC physical dest field to 8-bit dest field for > > xAPIC; fixes ES7000/ONE kexec timer hang > > > > Is there a changelog file in the kernel for kexec somewhere, or does > > this belong in the source file's comments somewhere? I can fix up the > > patch as soon as I know where the right spot for the description is. :) > > We use a source code management system for changelogs. (git) > > Patch comments (changelog info) go in the email at the top of the > patch. See Documentation/SubmittingPatches and > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt > and http://linux.yyz.us/patch-format.html for more info. > > --- > ~Randy
Thanks for the pointers! I've bookmarked them for future reference, and sent a new patch that follows the guidelines. :) -- Ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
