On 12/04/16 18:54, Mathieu Poirier wrote:
The amount of #define, enumeration and structure definition is big enough to justify moving them to a new header file.
+/* TMC_STS - 0x00C */ +#define TMC_STS_TRIGGERED BIT(1)
...
+#define TMC_AXICTL_WR_BURST_LEN 0xF00
Nit: The value above signifies, 16 data transfers per burst. So ideally it would be good to rename it to reflect that. say, TMC_AXICTL_WR_BURST_16
+/* TMC_FFCR - 0x304 */ +#define TMC_FFCR_EN_FMT BIT(0) +#define TMC_FFCR_EN_TI BIT(1) +#define TMC_FFCR_FON_FLIN BIT(4) +#define TMC_FFCR_FON_TRIG_EVT BIT(5) +#define TMC_FFCR_FLUSHMAN BIT(6) +#define TMC_FFCR_TRIGON_TRIGIN BIT(8) +#define TMC_FFCR_STOP_ON_FLUSH BIT(12) + +#define TMC_STS_TMCREADY_BIT 2
+#define TMC_FFCR_FLUSHMAN_BIT 6
nit: It would be nice to group the STS_ and FFCR_ bits together. Also I see that the defintion for TMC_STS_FULL is added in a completely unrelated patch (TMC-ETF AUX SPACE patch ?). It would be good to add it either here or in a different patch. Otherwise looks good. Reviewed-by: Suzuki K Poulose <suzuki.poul...@arm.com> Thanks Suzuki
