On 4/12/2016 1:13 PM, Frank Rowand wrote: > Hi Tony, < snip >
> With that change, the bulk of your patch looks good, with > minor changes: > > __of_device_is_available() would not need to change. > > __of_device_is_incomplete() would change to check the new > boolean property. (And I would suggest renaming it to > something that conveys it is ok to power manage the > device, but do not do anything else to the device.) > > -Frank One more thought... Are there multiple drivers that need to follow this pattern, or just one at the moment? If just one driver, then I would suggest open-coding accessing the property in the probe routine instead of adding the helper functions. If more drivers appear with the same pattern then the helper functions could be added. -Frank
