On 06/04/16 18:26, Brian Norris wrote: > On Sun, Mar 27, 2016 at 05:10:55PM -0400, Paul Gortmaker wrote: >> The Kconfig for this driver is currently: >> >> config BRCMSTB_GISB_ARB >> bool "Broadcom STB GISB bus arbiter" >> >> ...meaning that it currently is not being built as a module by anyone. >> Lets remove all modular references, so that when reading the driver >> there is no doubt it is builtin-only. >> >> Since module_init translates to device_initcall in the non-modular >> case, the init ordering remains unchanged with this commit. >> >> Cc: Brian Norris <[email protected]> >> Cc: Gregory Fong <[email protected]> >> Cc: Florian Fainelli <[email protected]> >> Cc: [email protected] >> Signed-off-by: Paul Gortmaker <[email protected]> > > I think this driver probably doesn't make too much sense as a module > anyway (among other things, we can't hook the ARM fault handler beyond > init time, as it's marked __init). So: > > Acked-by: Brian Norris <[email protected]> > > Might be good to get Florian's ack though, as I'm not using this > platform any more.
I concur with Brian here, your changes look good: Acked-by: Florian Fainelli <[email protected]> Thanks Paul -- Florian
