> From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Monday, April 11, 2016 3:15 PM > To: Joerg Roedel; Wan, Vincent > Cc: io...@lists.linux-foundation.org; linux-kernel@vger.kernel.org; kernel- > janit...@vger.kernel.org > Subject: [patch] iommu/amd: Signedness bug in acpihid_device_group() > > "devid" needs to be signed for the error handling to work. > > Fixes:b097d11a0fa3f ('iommu/amd: Manage iommu_group for ACPI HID > devices') > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> > > diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c > index c430c10..12f7779 100644 > --- a/drivers/iommu/amd_iommu.c > +++ b/drivers/iommu/amd_iommu.c > @@ -283,7 +283,7 @@ static struct iommu_dev_data *get_dev_data(struct > device *dev) static struct iommu_group *acpihid_device_group(struct device > *dev) { > struct acpihid_map_entry *p, *entry = NULL; > - u16 devid; > + int devid;
Sure, thanks for your patch. Wan Zongshun. > > devid = get_acpihid_device_id(dev, &entry); > if (devid < 0)
