On Mon, Mar 21, 2016 at 3:05 PM, Andi Kleen <a...@firstfloor.org> wrote: >> Please add a patch before this one that renames gs to gsbase. This is >> unreadable as is. > > I investigated this now, and it's not straight forward because on 32bit > ->gs is actually gsindex, not gsbase. So with a straight rename you > would end up with index in base on 32bit, which would be confusing. >
I would take this inconsistency as a reason why this needs to be fixed before any further changes are made. The variables should be called "gsbase" and "gsindex", full stop. It's not particularly risky -- we could even compare the generated code if we cared. --Andy
