Returning PTR_ERR(legacy_intc_node) is zero which is success but we want to return a negative error code.
Fixes: 4337ea1d4b10 ('PCI: xilinx-nwl: Add support for Xilinx NWL PCIe Host Controller') Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> diff --git a/drivers/pci/host/pcie-xilinx-nwl.c b/drivers/pci/host/pcie-xilinx-nwl.c index 7a2dc2e..5139e64 100644 --- a/drivers/pci/host/pcie-xilinx-nwl.c +++ b/drivers/pci/host/pcie-xilinx-nwl.c @@ -525,7 +525,7 @@ static int nwl_pcie_init_irq_domain(struct nwl_pcie *pcie) legacy_intc_node = of_get_next_child(node, NULL); if (!legacy_intc_node) { dev_err(pcie->dev, "No legacy intc node found\n"); - return PTR_ERR(legacy_intc_node); + return -EINVAL; } pcie->legacy_irq_domain = irq_domain_add_linear(legacy_intc_node,