-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Monday, January 08, 2007 8:11 AM
To: Linus Torvalds
Cc: Tobias Diedrich; Lu, Yinghai; Andrew Morton; Adrian Bunk; Andi
Kleen; Linux Kernel Mailing List
Subject: [PATCH 4/4] x86_64 ioapic: Improve the heuristics for when
check_timer fails.
>+static int check_timer_pin(int apic, int pin)
>+{
>+ int irq, idx;
>+ /*
>+ * Test the architecture default i8254 timer pin
>+ * of apic 0 pin 2.
>+ */
Comments need to be updated.
>+
>+
>+ /* If the apic pin pair is in use by another irq fail */
>+ irq = irq_from_pin(apic, pin);
>+ if ((irq != -1) && (irq != 0)) {
>+ apic_printk(APIC_VERBOSE,KERN_INFO "...apic %d pin % in
use by irq %d\n",
>+ apic, pin, irq);
>+ return 0;
>+ }
>+
>+ /* Add an entry in mp_irqs for irq 0 */
>+ idx = update_irq0_entry(apic, pin);
>+
>+ /* Add an entry in irq_to_pin */
>+ add_pin_to_irq(0, apic, pin);
>+
>+ /* Now setup the irq */
>+ setup_IO_APIC_irq(apic, pin, idx, 0);
>+
>+ /* And finally check to see if the irq works */
>+ return do_check_timer_pin(apic, pin);
>+}
>+
Did you miss to call irq_from_pin before add_pin_to_irq? You defined
irq_from_pin in PATCH 2/4.
YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
