On 03/11/16 at 02:21pm, dyo...@redhat.com wrote:
> @@ -231,7 +231,8 @@ static ssize_t __read_vmcore(char *buffe
>
> list_for_each_entry(m, &vmcore_list, list) {
> if (*fpos < m->offset + m->size) {
> - tsz = min_t(size_t, m->offset + m->size - *fpos,
> buflen);
> + tsz = (size_t)min_lt(m->offset + m->size - *fpos,
> + buflen);
> start = m->paddr + *fpos - m->offset;
> tmp = read_from_oldmem(buffer, tsz, &start, userbuf);
> if (tmp < 0)
> @@ -461,7 +462,7 @@ static int mmap_vmcore(struct file *file
> if (start < m->offset + m->size) {
> u64 paddr = 0;
>
> - tsz = min_t(size_t, m->offset + m->size - start, size);
> + tsz = (size_t)min_lt(m->offset + m->size - start, size);
> paddr = m->paddr + start - m->offset;
> if (vmcore_remap_oldmem_pfn(vma, vma->vm_start + len,
> paddr >> PAGE_SHIFT, tsz,
Hi, Dave.
Seems the previous parameter is unsigned long long, and the later one is
size_t. The size of both these types doesn't change in running time, why
not use min_t(unsigned long long, a, b) instead?
Thanks
Minfei
