Hi Kyle, Looks good. Just one nit and one comment.
On Sun, 7 Jan 2007 10:40:45 -0500 Kyle McMartin <[EMAIL PROTECTED]> wrote:
>
> diff --git a/kernel/compat.c b/kernel/compat.c
> index 6952dd0..cebb4c2 100644
> --- a/kernel/compat.c
> +++ b/kernel/compat.c
.
.
.
> + __put_user (s.uptime, &info->uptime) ||
^
We don't put spaces in here ...
> +asmlinkage long sys_sysinfo(struct sysinfo __user *info)
> +{
> + struct sysinfo val;
> +
> + do_sysinfo(&val);
>
> - out:
> if (copy_to_user(info, &val, sizeof(struct sysinfo)))
> return -EFAULT;
People have complined before that this adds a whole stack frame to the
"normal" syscall path. Personally I don't care, but it has been
mentioned.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp6LIRsRDDcE.pgp
Description: PGP signature
