On Saturday 06 January 2007 19:25, Randy Dunlap wrote: > On Fri, 5 Jan 2007 20:36:05 +0100 Olaf Hering wrote: > > > > Weird, who failed to run this command before adding new stuff?! > > find * -type f -print0 | xargs -0 env -i grep -nw register_sysrq_key > > > > sysrq x is for xmon, see arch/powerpc/xmon/xmon.c > > Better switch the new stuff to 'z' or 'w'
Also used: * c for kexec/crashdump and emac (drivers/net/ibm_emac/ibm_emac_debug.c) * g for KGDB on ppc > From: Randy Dunlap <[EMAIL PROTECTED]> > > SysRq showBlockedTasks is not done via B or T, it's done via W, > so put that in the Help message. > > It was previously done via X, but X is already used for Xmon > on powerpc platforms and this collision needs to be avoided. > @@ -342,8 +342,8 @@ static struct sysrq_key_op *sysrq_key_ta > &sysrq_mountro_op, /* u */ > /* May be assigned at init time by SMP VOYAGER */ > NULL, /* v */ Nice marker that v is in use. > - NULL, /* w */ > - &sysrq_showstate_blocked_op, /* x */ > + &sysrq_showstate_blocked_op, /* w */ > + NULL, /* x */ Wouldn't it be better to also put an marker for xmon here? And marker for 'c' and 'g' (maybe even 'h')? > NULL, /* y */ > NULL /* z */ > }; Also Documentation/sysrq.txt is not uptodate. It is missing c (emac meaning), d (lockdep), n (un-RT), q (timer), w (blocked) and x (xmon), but is documenting 'l' with no longer seems to be implemented. Torsten - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
