> From: Phil Pokorny [mailto:[email protected]]
>
> While you are in drivers/watchdog/hpwdt.c replacing panic() with
> nmi_panic() can you also fix a few more of the broken strings? The
> Linux style guide specfiically says NOT to break strings that are user
> visible because it breaks "grep". So:
Ahh, yes. I should have fixed this as well as the former case.
But this patch set has already been queued into -mm tree, so
I'll leave this patch if the fix is not important.
Regards,
Hidehiro Kawai
>
> - panic("An NMI occurred. Depending on your system the reason "
> + nmi_panic(regs, "An NMI occurred. Depending on your system the reason
> "
> "for the NMI is logged in any one of the following "
> "resources:\n"
> "1. Integrated Management Log (IML)\n"
>
> Should probably be:
>
> - panic("An NMI occurred. Depending on your system the reason "
> - "for the NMI is logged in any one of the following "
> - "resources:\n"
> + nmi_panic(regs, "An NMI occurred. Depending on your system the
> reason for the NMI is logged in any one of the following resources:\n"
> "1. Integrated Management Log (IML)\n"
>
> So it's okay to break on "\n", but not in the middle of a line.
>
> --
> Philip Pokorny, RHCE
> Chief Technology Officer
> PENGUIN COMPUTING, Inc
> www.penguincomputing.com
>
> Changing the world through technical innovation
