On March 2, 2016 6:43:14 PM PST, Stephen Rothwell <s...@canb.auug.org.au> wrote: >Hi Josh, > >Just a couple of quick comments ... > >On Wed, 2 Mar 2016 18:39:37 -0600 Josh Poimboeuf <jpoim...@redhat.com> >wrote: >> >> diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile >> index c4f0713..e4a6bd5 100644 >> --- a/tools/objtool/Makefile >> +++ b/tools/objtool/Makefile > >I was wondering if this would be more appropriate in scripts/objtool >since it is used during the building of the kernel. Or does it have a >wider use? > >> @@ -7,13 +7,19 @@ ARCH := x86 >> endif >> endif >> >> +# always use the host compiler >> +CC = gcc > >We have HOSTCC with its associated HOSTCFLAGS etc ... I am not sure if >that is more appropriate (but it does take care of people using clang).
This is what HOSTCC is for. And yes, this belongs in scripts. -- Sent from my Android device with K-9 Mail. Please excuse brevity and formatting.