Hi Masami, On Thu, 2016-02-25 at 18:19 +0900, Masami Hiramatsu wrote: > Add a test for log2 modifier of hist trigger in hist_mod.tc. > Here is the test result. > > ---- > # ./ftracetest test.d/trigger/trigger-hist-mod.tc > === Ftrace unit tests === > [1] event trigger - test histogram modifiers [PASS] > > # of passed: 1 > # of failed: 0 > # of unresolved: 0 > # of untested: 0 > # of unsupported: 0 > # of xfailed: 0 > # of undefined(test bug): 0 > ---- > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu...@hitachi.com> > Cc: Steven Rostedt <rost...@goodmis.org> > Cc: Ingo Molnar <mi...@redhat.com> > Cc: Shuah Khan <shua...@osg.samsung.com> > Cc: Namhyung Kim <namhy...@kernel.org> > Cc: Tom Zanussi <tom.zanu...@linux.intel.com> > --- > > Hi Tom, here is the patch to add a test for log2 modifier on your branch. >
Thanks! I'll add it to my branch. Tom > Thanks, > --- > .../ftrace/test.d/trigger/trigger-hist-mod.tc | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git > a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc > b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc > index 57e350a..c2b61c4 100644 > --- a/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc > +++ b/tools/testing/selftests/ftrace/test.d/trigger/trigger-hist-mod.tc > @@ -60,6 +60,16 @@ for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done > grep "id: sys_" events/raw_syscalls/sys_exit/hist > /dev/null || \ > fail "syscall modifier on raw_syscalls/sys_exit did not work" > > + > +reset_trigger > + > +echo "Test histgram with log2 modifier" > + > +echo 'hist:keys=bytes_req.log2' > events/kmem/kmalloc/trigger > +for i in `seq 1 10` ; do ( echo "forked" > /dev/null); done > +grep 'bytes_req: ~ 2^[0-9]*' events/kmem/kmalloc/hist > /dev/null || \ > + fail "log2 modifier on kmem/kmalloc did not work" > + > do_reset > > exit 0 > >
