On 18-02-16, 02:30, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki <rafael.j.wyso...@intel.com> > > Some fields in struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s > are only used for a limited set of CPUs. Namely, if a policy is > shared between multiple CPUs, those fields will only be used for one > of them (policy->cpu). This means that they really are per-policy > rather than per-CPU and holding room for them in per-CPU data > structures is generally wasteful. Also moving those fields into > per-policy data structures will allow some significant simplifications > to be made going forward. > > For this reason, introduce struct cs_policy_dbs_info and > struct od_policy_dbs_info to hold those fields. Define each of the > new structures as an extension of struct policy_dbs_info (such that > struct policy_dbs_info is embedded in each of them) and introduce > new ->alloc and ->free governor callbacks to allocate and free > those structures, respectively, such that ->alloc() will return > a pointer to the struct policy_dbs_info embedded in the allocated > data structure and ->free() will take that pointer as its argument. > > With that, modify the code accessing the data fields in question > in per-CPU data objects to look for them in the new structures > via the struct policy_dbs_info pointer available to it and drop > them from struct od_cpu_dbs_info_s and struct cs_cpu_dbs_info_s.
Fantastic, that's what I just suggested in the previous patch :) Acked-by: Viresh Kumar <viresh.ku...@linaro.org> -- viresh
