On Sun, Feb 14, 2016 at 03:00:52PM -0500, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/platform/x86/Kconfig:config INTEL_SCU_IPC > drivers/platform/x86/Kconfig: bool "Intel SCU IPC Support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We explicitly disallow a driver unbind, since that doesn't have a > sensible use case anyway, and it allows us to drop the ".remove" > code for non-modular drivers. > > Since module_pci_driver() uses the same init level priority as > builtin_pci_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We don't replace module.h with init.h since the file already has that. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments.
Alan, Sreedhara, any objection to Paul's changes? This appears to have been introduced as bool in the original commit. -- Darren Hart Intel Open Source Technology Center
