On Wed, 10 Feb 2016, Stephen Boyd wrote: > On 02/10, Lee Jones wrote: > > On Mon, 08 Feb 2016, Stephen Boyd wrote: > > > > > Convert this driver to use clkdev_create() instead of > > > clk_register_clkdevs(). The latter API is only used by this driver, > > > although this driver only allocates one clk to add anyway. > > > Furthermore, this driver allocates the clk_lookup structure with > > > devm, but clkdev_drop() will free that structure when passed, > > > leading to a double free when this driver is removed. Clean it > > > all up and pave the way for the removal of clk_register_clkdevs(). > > > > > > Cc: Lee Jones <lee.jo...@linaro.org> > > > Cc: Andy Shevchenko <andriy.shevche...@linux.intel.com> > > > Cc: Russell King <li...@arm.linux.org.uk> > > > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > > > --- > > > drivers/mfd/intel_quark_i2c_gpio.c | 26 +++++++++----------------- > > > 1 file changed, 9 insertions(+), 17 deletions(-) > > > > I never much liked this code [0] > > > > Glad for it to be simplified. > > > > Applied, thanks. > > > > Can you please ack the patch instead? I'd like to take it through > the clk tree so that I can remove clk_register_clkdevs() as well.
I'll make a branch you can pull from. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
