On Thu, 2006-12-28 at 19:41 +0100, Daniel Marjamäki wrote: > Hello all! > > I sent a patch with this content: > > - for (i = 0; i < MAX_PIRQS; i++) > - pirq_entries[i] = -1; > + memset(pirq_entries, -1, sizeof(pirq_entries)); > > I'd like to know if you have any comments to this change. It was of > course my intention to make the code shorter, simpler and faster.
Hi, personally I don't like the new code; memset only takes a byte as argument and while it probably is the same, that is now implicit behavior and no longer explicit. A reasonably good compiler will notice it's the same and generate the best code anyway, so I would really really suggest to go for the best readable code, which imo is the original code. Greetings, Arjan van de Ven - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
