Hi,
On Sun, Feb 07, 2016 at 10:26:51AM -0800, Joe Perches wrote:
> On Sun, 2016-02-07 at 17:38 +0000, Luis Henriques wrote:
> > Instead of defining a local version of struct ethhdr use the standard
> > definition from .
>
> trivia:
>
> > diff --git a/arch/powerpc/platforms/ps3/gelic_udbg.c
> > b/arch/powerpc/platforms/ps3/gelic_udbg.c
> []
> > @@ -173,8 +169,8 @@ static void gelic_debug_init(void)
> >
> > h_eth = (struct ethhdr *)dbg.pkt;
> >
> > - memset(&h_eth->dest, 0xff, 6);
> > - memcpy(&h_eth->src, &mac, 6);
> > + memset(&h_eth->h_dest, 0xff, 6);
> > + memcpy(&h_eth->h_source, &mac, 6);
>
> Be nice to use ETH_ALEN and eth_broadcast_addr.
> Maybe ether_addr_copy too.
>
> > @@ -183,7 +179,7 @@ static void gelic_debug_init(void)
> > GELIC_LV1_VLAN_TX_ETHERNET_0, 0, 0,
> > &vlan_id, &v2);
> > if (!result) {
> > - h_eth->type = 0x8100;
> > + h_eth->h_proto= 0x8100;
>
> ETH_P_8021Q
>
> > header_size += sizeof(struct vlantag);
> > h_vlan = (struct vlantag *)(h_eth + 1);
> > @@ -191,7 +187,7 @@ static void gelic_debug_init(void)
> > h_vlan->subtype = 0x0800;
> > h_ip = (struct iphdr *)(h_vlan + 1);
> > } else {
> > - h_eth->type = 0x0800;
> > + h_eth->h_proto= 0x0800;
>
> ETH_P_IP
Great, I'll send out v2 that will include most of these comments. The
one I'll leave out is the usage of ether_addr_copy.
Thanks a lot for your comments.
Cheers,
--
Luís
