On Sun, Jan 24, 2016 at 10:53:23PM +0900, Namhyung Kim wrote:
> Hello,
> 
> This patchset tries to implement percent limit to callchains which was
> requested by Andi Kleen.  For some reason, limiting callchains by
> (overhead) percentage didn't work well.  This patch fixes it and make
> --percent-limit also works for callchains as well as hist entries.
> 
> This is available on 'perf/callchain-limit-v1' branch in my tree:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
> 
> Any comments are welcome,
> 
> Thanks,
> Namhyung
> 
> 
> Namhyung Kim (12):
>   perf report: Apply --percent-limit to callchains also
>   perf report: Apply callchain percent limit on --stdio
>   perf report: Get rid of hist_entry__callchain_fprintf()
>   perf report: Fix percent calculation on --stdio
>   perf report: Hide output pipe for percent-limited callchains on stdio
>   perf hists browser: Fix dump to show correct callchain style
>   perf hists browser: Fix callchain_node__count_rows()
>   perf hists browser: Apply callchain percent limit
>   perf hists browser: Fix callchain counting when press ENTER key
>   perf hists browser: Fix counting callchains when expand/collapse all
>   perf hists browser: Update percent base for fractal callchain mode
>   perf report: Fix callchain percent limit on --gtk

is 0.5 the default or one has to use the --percent-limit 0.5
for the limit to be effective?

without the option I'm getting empty callchains that are below 0.5
but only in TUI mode (attached).. --stdio shows them all unfolded

thanks,
jirka



---
+   46.69%    46.69%  ls       [kernel.vmlinux]  [k] intel_bts_enable_local     
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_pmu_enable.part.87    
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] 
perf_event_context_sched_in                                                     
                                                                                
                                                                 ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_exec            
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] setup_new_exec             
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] load_elf_binary            
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] search_binary_handler      
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] do_execveat_common.isra.33 
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] sys_execve                 
                                                                                
                                                                                
                                      ▒
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] return_from_execve         
                                                                                
                                                                                
                                      ▒
-    0.08%     0.00%  perf     [unknown]         [k] 0x00007f2175b35e07         
                                                                                
                                                                                
                                      ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_nmi_handler     
                                                                                
                                                                                
                                      ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] nmi_handle                 
                                                                                
                                                                                
                                      ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] default_do_nmi             
                                                                                
                                                                                
                                      ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] do_nmi                     
                                                                                
                                                                                
                                      ▒
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] end_repeat_nmi             
                                                                                
                                                                                
                                      ▒
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable             
                                                                                
                                                                                
                                      ▒
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write      
                                                                                
                                                                                
                                      ▒

Reply via email to