On Wed, 20 Dec 2006, Dave Kleikamp wrote:
>
> This patch removes some questionable code that attempted to make a
> no-longer-used page easier to reclaim.
If so, "cancel_dirty_page()" may actually be the right thing to use, but
only if you can guarantee that the page isn't mapped anywhere (and from
the name of the function I guess it's not something that you'll ever map?)
So the JFS code _looks_ like you could just replace the
clear_page_dirty(page);
with
cancel_dirty_page(page, PAGE_CACHE_SIZE);
(where that second parameter is just used for statistics - it updates the
"cancelled IO" byte-counts if CONFIG_TASK_IO_ACCOUNTING is set - so the
number doesn't really matter, you could make it zero if you never want the
thing to show up in the IO accounting).
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
