On Mon, Jan 25, 2016 at 09:30:47AM +0000, Singhal, Maneesh wrote: > Thanks Johannes for generously reviewing my patch. It indeed is going to > improve the thing a lot. I agree with all your comments so far, and will > submit a newer patch soon. > Since this is my first patch, I have couple of questions regarding submitting > the patch: > > 1. Is there a page/place where I can see the review comments rather neatly > ?, finding out all the comments and infact reading to entire code on text > file is cumbersome. If there is no way, then its fine,... I can live with it.
Nope unfortunately not. That's why it's nice when people trim their e-mails ;-) > 2. When I address the review comments and want to resubmit the patch, do I > need to submit the incremental patch or the entire code patch again ? > git-format-patch gives me incremental patch only. Ususally you change your code and do a git commit --amend. This modifies your commit instead of creating a new one. If you already have a new commit than you can use git rebase -i <version befor commit to amend> and squash the commit's into one (git gives you a nice readme when doing rebase -i). Afterwards you do a git format-patch -1 -v 2, this creates a v2-0001-your-patch-name.patch for git send-email which has an updated [PATCH V2] in the subject. At least, the above is the way I do it (i.e. there are more than one ways to do it). -- Johannes Thumshirn Storage jthumsh...@suse.de +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
